Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ability to add deployment labels and annotations #355

Merged
merged 2 commits into from
Nov 5, 2024
Merged

feat: ability to add deployment labels and annotations #355

merged 2 commits into from
Nov 5, 2024

Conversation

dadangnh
Copy link
Contributor

Hi,

This PR adds the ability to specify custom labels and annotations for the deployment in the Helm chart.

Thanks

martin-helmich
martin-helmich previously approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@martin-helmich martin-helmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the version bump (will be done automatically upon release), but LGTM otherwise. Thanks for your contribution. 👍

deploy/helm-chart/kubernetes-replicator/Chart.yaml Outdated Show resolved Hide resolved
@martin-helmich martin-helmich enabled auto-merge (squash) November 5, 2024 12:29
@martin-helmich martin-helmich merged commit d750403 into mittwald:master Nov 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-helmich martin-helmich martin-helmich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dadangnh @martin-helmich