implement crashLoopBackOff for failed processes #64
Conversation
+ `maxAttemps = -1` will restart the job forever
pkg/proc/job_common.go
Outdated
| if maxAttempts == 0 { | ||
| maxAttempts = 3 | ||
| } |
There was a problem hiding this comment.
Also (I know from the diff that that's not new behaviour, but still) it's come to my attention that it's annoying for some users (see #62) that you cannot actually set maxAttempts to 0 (because that counts as "not set", and will default to 3). Should we maybe think about solving this differently?
There was a problem hiding this comment.
Sure, there are some possibilities that make sense in my opinion. But I can't decide which one is the "best":
-
the current method from this pr since by default I still have 3 tries if
maxAttemptsis not set. With-1you can set infinite. -
maxAttempts = 0means infinite. Against this, however, is that the behavior changes to before and that could possibly be unexpected as well. In addition, you cannot set the job to be executed only once. -
maxAttempts = ' actually means
0attempts. Then infinity would still mean-1. I think this is the nicest solution, but it is also not backward compatible.
There was a problem hiding this comment.
I would also lean towards option 3; one thing I could (possibly) think of would be to change the maxAttempts type in the configuration *int (if supported by the HCL parser), so that we could differentiate between "not set" (maxAttempts == nil) and "explicitly set to 0" (*maxAttempts == 0)?
maxAttemps = -1will restart the job foreverfixes #63