fix: test: update expectations

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
miurahr · Aug 4, 2024 · 6c2960d · 6c2960d
1 parent b773467
commit 6c2960d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 30 deletions.
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -54,26 +54,6 @@ def test_cli_help(capsys):
     assert expected_help(out)
 
 
-@pytest.mark.parametrize(
-    "qt_version, modules, unexpected_modules",
-    (
-        ("5.11.3", ["qtcharts", "qtwebengine"], []),
-        ("5.11.3", ["not_exist"], ["not_exist"]),
-        ("5.11.3", ["qtcharts", "qtwebengine", "not_exist"], ["not_exist"]),
-        ("5.11.3", None, []),
-        ("5.15.0", ["Unknown"], ["Unknown"]),
-    ),
-)
-def test_cli_select_unexpected_modules(qt_version: str, modules: Optional[List[str]], unexpected_modules: List[str]):
-    cli = Cli()
-    cli._setup_settings()
-    assert cli._select_unexpected_modules(qt_version, modules) == unexpected_modules
-
-    nonexistent_qt = "5.16.0"
-    assert cli._select_unexpected_modules(nonexistent_qt, modules) == sorted(modules or [])
-
-
-
 @pytest.mark.parametrize(
     "host, target, arch, version_or_spec, expected_version, is_bad_spec",
     (

diff --git a/tests/test_install.py b/tests/test_install.py
@@ -1194,26 +1194,20 @@ def test_install(
         (
             "install-qt windows desktop 5.16.0 win32_mingw73",
             None,
-            'WARNING : Specified Qt version "5.16.0" did not exist when this version of aqtinstall was released. '
-            "This may not install properly, but we will try our best.\n"
             "ERROR   : Failed to locate XML data for Qt version '5.16.0'.\n"
             "==============================Suggested follow-up:==============================\n"
             "* Please use 'aqt list-qt windows desktop' to show versions available.\n",
         ),
         (
             "install-qt windows desktop 5.15.0 bad_arch",
             "windows-5150-update.xml",
-            'WARNING : Specified target combination "windows desktop bad_arch" did not exist when this version of '
-            "aqtinstall was released. This may not install properly, but we will try our best.\n"
             "ERROR   : The packages ['qt_base'] were not found while parsing XML of package information!\n"
             "==============================Suggested follow-up:==============================\n"
             "* Please use 'aqt list-qt windows desktop --arch 5.15.0' to show architectures available.\n",
         ),
         (
             "install-qt windows desktop 5.15.0 win32_mingw73 -m nonexistent foo",
             "windows-5150-update.xml",
-            "WARNING : Specified modules ['foo', 'nonexistent'] did not exist when this version of aqtinstall "
-            "was released. This may not install properly, but we will try our best.\n"
             "ERROR   : The packages ['foo', 'nonexistent', 'qt_base'] were not found"
             " while parsing XML of package information!\n"
             "==============================Suggested follow-up:==============================\n"
@@ -1251,17 +1245,13 @@ def test_install(
         (
             "install-tool windows desktop tools_vcredist nonexistent",
             "windows-desktop-tools_vcredist-update.xml",
-            'WARNING : Specified target combination "windows tools_vcredist nonexistent" did not exist when this version of '
-            "aqtinstall was released. This may not install properly, but we will try our best.\n"
             "ERROR   : The package 'nonexistent' was not found while parsing XML of package information!\n"
             "==============================Suggested follow-up:==============================\n"
             "* Please use 'aqt list-tool windows desktop tools_vcredist' to show tool variants available.\n",
         ),
         (
             "install-tool windows desktop tools_nonexistent nonexistent",
             None,
-            'WARNING : Specified target combination "windows tools_nonexistent nonexistent" did not exist when this '
-            "version of aqtinstall was released. This may not install properly, but we will try our best.\n"
             "ERROR   : Failed to locate XML data for the tool 'tools_nonexistent'.\n"
             "==============================Suggested follow-up:==============================\n"
             "* Please use 'aqt list-tool windows desktop' to show tools available.\n",