Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete combination check #812

Merged
merged 12 commits into from
Aug 17, 2024
Merged

Conversation

miurahr
Copy link
Owner

@miurahr miurahr commented Aug 4, 2024

Checking Qt version and modules combination become unfeasible, because release of new versions are frequent.
Also aqtinstall now have a feature to list versions, modules, archives.

This is a proposal of removal of combination check feature.

  • Delete combinations.json and relevant CI script to update it
  • Delete feature to print warning with check combinations
  • Delete Settings class methods and field to examine combination database
  • Remove tests to check combinations
  • Update expectation of tests, which expect showing warn.

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
docs/CHANGELOG.rst Outdated Show resolved Hide resolved
Co-authored-by: Mozi <29089388+pzhlkj6612@users.noreply.github.com>
docs/CHANGELOG.rst Outdated Show resolved Hide resolved
fix: remove logic to check or warn about unknown combinations
Copy link
Contributor

@pzhlkj6612 pzhlkj6612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@miurahr miurahr merged commit 73fc45e into master Aug 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants