Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getinfo() #609

Merged
merged 4 commits into from
Aug 8, 2024
Merged

feat: add getinfo() #609

merged 4 commits into from
Aug 8, 2024

Conversation

Ravencentric
Copy link
Contributor

Pull request type

  • Feature enhancement

Which ticket is resolved?

What does this PR change?

Implement ZipFile's getinfo
https://docs.python.org/3/library/zipfile.html#zipfile.ZipFile.getinfo

@Ravencentric
Copy link
Contributor Author

Ravencentric commented Aug 8, 2024

One thing to note, getinfo accepts names ending with or without / (similar to TarFile). This allows for more interoperability with ZipFile. Do let me know if we don't want to support this. If we do want to support this, I reckon it should be done on other methods too like extract() and read() too

@miurahr
Copy link
Owner

miurahr commented Aug 8, 2024

LGTM.

@miurahr miurahr merged commit 5a3e9e3 into miurahr:master Aug 8, 2024
24 checks passed
@Ravencentric Ravencentric deleted the getinfo branch August 9, 2024 06:11
This was referenced Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add getinfo() method to get a single FileInfo by name
2 participants