Some fixes for the Behringer BCD3000 controls #13963
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Welcome and thanks for improving this! Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.
Please also rebase this on the 2.5 branch, so its released ASAP.
Comment on lines
-660
to
-669
| <control> | ||
| <status>0xb0</status> | ||
| <midino>0xd</midino> | ||
| <group>[Flanger]</group> | ||
| <key>lfoPeriod</key> | ||
| <description></description> | ||
| <options> | ||
| <normal/> | ||
| </options> | ||
| </control> |
There was a problem hiding this comment.
This leaves a knob unmapped, right? Which one exactly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.