(fix) Waveform scratching: fix seeking to hotcue while scratching is enabled #14059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
force-pushed
the
waveform-scratching-seek-fix
branch
2 times, most recently
from
6927fdc to
92095c1
Compare
ronso0
commented
Dec 27, 2024
| m_pRateControl->notifySeek(seekPosition); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Until now this was a no-op in RateControl and with the fix it's causing trouble so I removed it.
ronso0
force-pushed
the
waveform-scratching-seek-fix
branch
2 times, most recently
from
2ab9774 to
99d15da
Compare
ronso0
force-pushed
the
waveform-scratching-seek-fix
branch
from
99d15da to
e98e7ed
Compare
…ntrolProxy etc. Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
ronso0
force-pushed
the
waveform-scratching-seek-fix
branch
2 times, most recently
from
8d76989 to
2a4d536
Compare
…o hotcue adopt the seek position explicitly in order to avoid crazy seek speeds
ronso0
force-pushed
the
waveform-scratching-seek-fix
branch
from
2a4d536 to
dff5e6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first (still dirty) fix for #13981
TL;DR
No need to rush this into 2.6
Recently I compared the available methods for scratching with controllers, and while PositionScratchController (developed for waveform scratching) turned out to be the best (for me, no drift, smooth at low rates, nice spinback) I can't really use it as I want to due to #13981
This fixes the crazy seeking and allows seeking to a hotcue when the wheel is stopped or turned slowly.
It's good enough quickfix for me, and I can use PositionScratchController in my mapping for new year's eve.
Though this is just a first step to understand what's happeing with EngineBuffer, ReadAheadManager, RateControl and PositionScratchController. A real fix needs to be more robust, probably requiring some tweaks in EngineBuffer and other involved units.