feat: adds direction property to mj-social-element to reverse icon/text order #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestomasino
changed the title
|
Hi and thanks for the contribution! Can we rename this to |
|
Absolutely. I'll modify now. |
|
Updated, and also added it to the mjml-social-element readme properties list |
|
When will there be a release for this? I don't see it in the latest 4.15.3 package |
|
I'm also noticing this doesn't appear to be live in the newest |
|
Experimental branch has it and should be near a release state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running into a lot of situations in email builds, especially on links, where designers place an arrow or other image on the right side of the text. mj-social does a fantastic job with image/text layouts, but it was lacking an option to reverse the order of the image and the text. I've added a new property
directionas an enum of 'left' or 'right' which swaps the rendering of the TDs in the render method to support this change.