Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI Errors #266

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Fix CI Errors #266

merged 1 commit into from
Jun 21, 2024

Conversation

jkawamoto
Copy link
Contributor

This PR addresses recent CI errors. It includes the following changes:

@martinpopel
Copy link
Collaborator

@mjpost @ozancaglayan Do you agree with dropping support for Python 3.6 and 3.7 (which are end of life)?
I agree because I don't see any other easy way how to prevent CI failures in future (and we cannot officially support Python versions which we don't test with CI).

@ozancaglayan
Copy link
Collaborator

Hi. There's no reason to keep 3.6 and 3.7 there I agree. 3.8 is also coming to EOL October 2024. We could drop that one later as well.

Thanks for the PR!

@ozancaglayan
Copy link
Collaborator

It would be good to do a v2.4 release probably once merged.

@martinpopel martinpopel merged commit 333731a into mjpost:master Jun 21, 2024
19 checks passed
@mjpost
Copy link
Owner

mjpost commented Jun 21, 2024

Thanks, guys—I agree about dropping support. 2.4.2 was released a while ago; I don't think we need a new release with this PR?

@ozancaglayan
Copy link
Collaborator

I was looking at https://github.com/mjpost/sacrebleu/releases which shows 2.3.x as the latest.

@mjpost
Copy link
Owner

mjpost commented Jun 21, 2024

Ah, yeah, I should update that. It's a separate process. 2.4.2 is available on pypi.

@mjpost
Copy link
Owner

mjpost commented Jun 21, 2024

Actually I'm sure there's a way to do this:

  • Tag a release
  • Have it automatically pushed to pypi via Github action
  • Have it automatically released on Github via Github action

@ozancaglayan
Copy link
Collaborator

I dont have time currently but yes there is:

  • https://github.com/softprops/action-gh-release
  • Writing a new workflow that'll be triggered for new tags
  • for pushing to PyPI, we'll need to add PyPI credentials as SECRETS to the repo and you can just use the same shell commands in a run:  step

@jkawamoto jkawamoto deleted the ci branch June 21, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants