use_defaults() method passes extra arguments

[teunbrand]

Hi Matthew,

Pardon for the cold PR!
We discovered through reverse dependency checks that the way {ggdist}'s use_defaults() method is implemented is incompatible with a new feature we're planning for {ggplot2}.
The new feature is described in tidyverse/ggplot2#5833, but the TL;DR is that we want to allow geoms to derive their default aesthetics from a theme element.

This PR aims to make {ggdist} compatible that feature in {ggplot2}.
We aim to include that feature in the next version of ggplot2, which isn't scheduled to come out until next year.
I'd be happy to provide more context if needed!

Here is an example of {ggdist} + the new feature in action.

devtools::load_all("~/packages/test/ggdist/") # this PR
#> ℹ Loading ggdist
library(ggplot2)
packageVersion("ggplot2") # from the linked PR
#> [1] '3.5.1.9000'

df <- data.frame(x = rnorm(1000))

# Set default fill to be derived from theme
update_geom_defaults("slabinterval", aes(fill = from_theme(accent)))

# Using theme to set the default accent colour for geoms
ggplot(df, aes(x)) +
  stat_halfeye() +
  theme(geom = element_geom(accent = "dodgerblue"))

^{Created on 2024-07-19 with reprex v2.1.1}

[mjskay]

Ah cool, looks like a nice new feature!

No apologies for cold PR necessary :)

Thanks!