Populate cursor "messages" attribute when fast_executemany=True #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fast_executemany is True, function ExecuteMulti() is called instead of execute(). ExecuteMulti() was not calling GetDiagRecs() to populate the cursor "messages" attribute. Made GetDiagRecs() public for that purpose.
|
This looks really nice. Thanks for beefing up the test. I've never been fond of having two code paths that are so separate, regular and fast_execute_many. I'll be surprised if there aren't a lot of things like this. When the change was first submitted, I wanted to break things apart and make them use the same base components - especially binding parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fast_executemany is True, function ExecuteMulti() is called instead of execute(). ExecuteMulti() was not calling GetDiagRecs() to populate the cursor "messages" attribute. This now happens. I had to export GetDiagRecs() from cursor.cpp for that purpose.
Unit test added. Also beefed up an existing unit test for unicode messages.
Fixes #1299 .