Add support for hidden field #25
Conversation
steffendsommer
commented
Aug 29, 2018
steffendsommer
commented
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
====================================
Coverage 0% 0%
====================================
Files 13 13
Lines 231 233 +2
====================================
- Misses 231 233 +2
Continue to review full report at Codecov.
|
| @@ -3,7 +3,7 @@ | |||
| <label for="#(key)">#(label)</label> | |||
| } | |||
|
|
|||
| #bs:input("#get(type)", "form-control #if(hasErrors) { is-invalid }", "id='#(key)' name='#(key)' #if(value) { value='#(value)' } autofocus #if(isRequired) { required } #if(placeholder) { placeholder='#(placeholder)' }") | |||
| #bs:input("#get(type)", "form-control #if(hasErrors) { is-invalid }", "id='#(key)' name='#(key)' #if(value) { value='#(value)' } #if(isRequired) { required } #if(placeholder) { placeholder='#(placeholder)' }") | |||
There was a problem hiding this comment.
Good thing you removed autofocus as well. Why is #get(type) necessary? Can it be #(type)?
There was a problem hiding this comment.
Any thoughts on whether and how autofocus should be configurable?
There was a problem hiding this comment.
#get() isn't needed - removed that part. We could consider having an "additional attributes" parameter that could be based on to bs:input. Created an issue on it: #26
