🧹 NeuralNetwork cleanup pt. 2 -- data loading #1408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends some others PRs which should be merged first: #1407 #1388
This is primarily a cleanup of the internal workings of the NeuralNetworkData class. Step 2 of many.
loadData
. This might be temporary. I would have put it in the nnUtils but that is a class for no reason.this.data.raw
rather than passing them around as arguments.Possibly breaking changes:
text/plain
toapplication/json
.nn.normalizeData
no longer accepts an argument or returns a value.