Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 NeuralNetwork cleanup pt. 2 -- data loading #1408

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

lindapaiste
Copy link
Contributor

Extends some others PRs which should be merged first: #1407 #1388

This is primarily a cleanup of the internal workings of the NeuralNetworkData class. Step 2 of many.

  • Move file loading functions which are not NN-specific to utils/io.
  • Move the logic for finding the data array into a new file loadData. This might be temporary. I would have put it in the nnUtils but that is a class for no reason.
  • Prefer accessing instance properties like this.data.raw rather than passing them around as arguments.
  • Modified a bunch of internal NeuralNetworkData methods such that they just set/update the class properties and don't return anything.

Possibly breaking changes:

  • MIME type for JSON files changed from text/plain to application/json.
  • nn.normalizeData no longer accepts an argument or returns a value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant