Fix scoring bug, properly handeling nan
values
#780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing our benchmark scores, we want to "ignore" runs on a base workload, if the submission doesn't hit the target on the held-out workload. This is implemented here:
algorithmic-efficiency/scoring/performance_profile.py
Lines 322 to 328 in c465e25
However, the
variant_criteria_filter()
only checks fornp.inf
values (algorithmic-efficiency/scoring/performance_profile.py
Lines 245 to 257 in c465e25
But another invalid score that can occur is a
nan
. This happens, e.g. when running OOM. In this case, the base workload score should also be ignored.This PR fixes this issue. To properly do so, it also needs to load the list of held-out workloads (to drop all other workload variants that have only been computed for the baseline).