Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat default dropout in doc #806

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Feat default dropout in doc #806

wants to merge 8 commits into from
+20 −4

Conversation

init-22
Copy link

@init-22 init-22 commented Oct 31, 2024

Adding default dropout values for each workloads mentioned in this issue: #786

@init-22 init-22 requested a review from a team as a code owner October 31, 2024 17:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@init-22
Copy link
Author

init-22 commented Nov 2, 2024

recheck

@priyakasimbeg priyakasimbeg changed the base branch from main to dev November 14, 2024 18:19
priyakasimbeg
priyakasimbeg previously approved these changes Nov 14, 2024
View reviewed changes
@priyakasimbeg
Copy link
Contributor

Hi Isaac, thanks for this PR. Looks great.
Can we remove cifar10 and mnist from the table? Those two are implemented more for testing purposes and aren't part of the 8 AlgoPerf benchmarking workloads.

@priyakasimbeg
Copy link
Contributor

Also, can you sign the CLA with the email address you use for your github account so that the CLA check passes.
If it still does not pass, could you email support@mlcommons.org and ask for help with the CLA check in this PR.

@morphine00
Copy link
Contributor

Hi folks, the CLA check is passing. The code needs to be reviewed presumably by @priyakasimbeg (or anyone else in wg-algorithms). Note the message after the previous comment, " init-22 dismissed priyakasimbeg’s stale review via 76b084b 2 hours ago".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyakasimbeg priyakasimbeg priyakasimbeg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@init-22 @priyakasimbeg @morphine00