Don't handle untested and bugged case for excludes.
#771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
marcenacp
changed the title
exclude.
marcenacp
force-pushed
the
feature/efficient-filtering
branch
from
a142ebe
to
f3c5647
Compare
marcenacp
force-pushed
the
feature/efficient-filtering
branch
from
f3c5647
to
8d899f1
Compare
marcenacp
changed the title
exclude.excludes.
ccl-core
approved these changes
Nov 28, 2024
marcenacp
force-pushed
the
feature/efficient-filtering
branch
from
8d899f1
to
0b45c82
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, there's a bug. We should properly test this feature. For the time being, I remove the condition with the bug.