Handle non-capturing groups in regex transforms (partial-train/*.parquet).
#774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
marcenacp
force-pushed
the
feature/efficient-filtering-2
branch
from
58fff40
to
f0ef1aa
Compare
marcenacp
changed the title
partial-train/*.parquet).
marcenacp
force-pushed
the
feature/efficient-filtering-2
branch
from
f0ef1aa
to
0cbd32f
Compare
marcenacp
force-pushed
the
feature/efficient-filtering-2
branch
from
0cbd32f
to
2a5ee7e
Compare
ccl-core
approved these changes
Nov 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial issue handled in this PR is to cover for Hugging Face's regex pattern:
"default/(?:partial-)?(train|test)/.+parquet$".Indeed, in the parquet branch, when the dataset is not entirely moved to parquet, the folder may be called
partial-, so we have to handle those files.The difficulty is that
transform.regexis a regular expression whileincludesis a glob pattern, so we have to convert from one to the other.Before this PR, the following command fails:
mlcroissant load --jsonld https://huggingface.co/api/datasets/mlfoundations/dclm-baseline-1.0-parquet/croissant --record_set default --num_records 1 --debug --filters '{"default/split": "train"}'After this PR, it does succeed, although there's another regression: we download all parquet files before doing the join instead of joining file by file.