Drop all useless operations when we filter on a field - so we know its value in advance. #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
pierrot0
approved these changes
Nov 29, 2024
…know its value in advance.
marcenacp
force-pushed
the
feature/efficient-filtering-3
branch
from
4133e02
to
7ca7552
Compare
marcenacp
changed the title
ccl-core
reviewed
Nov 29, 2024
| @@ -248,6 +253,15 @@ def test_nonhermetic_loading(version, dataset_name, record_set_name, num_records | |||
| ["huggingface-c4/metadata.json", "data", 1, {"data/variant": "en"}], | |||
| ["huggingface-levanti/metadata.json", "levanti_train", 10, None], | |||
| ["huggingface-open-hermes/metadata.json", "default", 3, None], | |||
| # This dataset will timeout if the following feature is broken: mlcroissant | |||
There was a problem hiding this comment.
Shall we add a meaningful error message somewhere?
There was a problem hiding this comment.
I would rather keep it simple with a comment - otherwise it means intercepting pytest's timeout or create a timeout, etc
marcenacp
force-pushed
the
feature/efficient-filtering-3
branch
from
0136e47
to
908cb8a
Compare
marcenacp
force-pushed
the
feature/efficient-filtering-3
branch
from
908cb8a
to
4bcc63a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way, we can:
Instead of:
I also added a non-hermetic test which should timeout if there's a regression on this feature.