Skip to content

Commit

Permalink
Fix offline_min_samples in submission checker and #1569 (#1571)
Browse files Browse the repository at this point in the history
* Fix offline_min_samples in submission checker and #1569

* Removed mlperf.conf from llama2 directory to avoid confusion

* Update submission_checker.py
  • Loading branch information
arjunsuresh authored Jan 22, 2024
1 parent 16d312b commit f21c39d
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 76 deletions.
5 changes: 5 additions & 0 deletions language/llama2-70b/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@

## Prepare environment

Copy the mlperf.conf file to this folder.
```
cp ../../mlperf.conf .
```

For a CPU-only run:

```
Expand Down
74 changes: 0 additions & 74 deletions language/llama2-70b/mlperf.conf

This file was deleted.

22 changes: 20 additions & 2 deletions tools/submission/submission_checker.py
Original file line number Diff line number Diff line change
Expand Up @@ -1281,6 +1281,23 @@
"compliance_accuracy.txt",
]

OFFLINE_MIN_SPQ_SINCE_V4 = {
"resnet": 24576,
"retinanet": 24576,
"bert-99": 10833,
"bert-99.9": 10833,
"dlrm-v2-99": 24576,
"dlrm-v2-99.9": 24576,
"3d-unet-99": 43,
"3d-unet-99.9": 43,
"rnnt": 2513,
"gptj-99": 13368,
"gptj-99.9": 13368,
"llama2-70b-99": 24576,
"llama2-70b-99.9": 24576,
"stable-diffusion-xl": 5000
}

SCENARIO_MAPPING = {
"singlestream": "SingleStream",
"multistream": "MultiStream",
Expand Down Expand Up @@ -1526,7 +1543,7 @@ def __init__(
self.seeds = self.base["seeds"]
self.test05_seeds = self.base["test05_seeds"]
self.accuracy_target = self.base["accuracy-target"]
self.accuracy_upper_limit = self.base["accuracy-upper-limit"]
self.accuracy_upper_limit = self.base.get("accuracy-upper-limit", {})
self.performance_sample_count = self.base["performance-sample-count"]
self.latency_constraint = self.base.get("latency-constraint", {})
self.min_queries = self.base.get("min-queries", {})
Expand Down Expand Up @@ -2082,7 +2099,8 @@ def check_performance_dir(
)
is_valid = False

if scenario == "Offline" and (samples_per_query < OFFLINE_MIN_SPQ):
if config.version in ["v0.5", "v0.7", "v1.0", "v1.1", "v2.0", "v2.1", "v3.0", "v3.1"] and scenario == "Offline" and (samples_per_query < OFFLINE_MIN_SPQ) or \
scenario == "Offline" and (samples_per_query < OFFLINE_MIN_SPQ_SINCE_V4[model]):
log.error(
"%s Required minimum samples per query not met by user config, Expected=%s, Found=%s",
fname,
Expand Down

0 comments on commit f21c39d

Please sign in to comment.