Check seeds are always logged #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
@pgmpablo157321 could we add support to bypass this seed check in case someone wants to resubmit logs from a previous round and those logs don't have the seed value being reported? |
pgmpablo157321
force-pushed
the
seed_checker_updates
branch
from
19d10ce
to
d2bce16
Compare
pgmpablo157321
force-pushed
the
seed_checker_updates
branch
from
d2bce16
to
24bed7e
Compare
|
@ShriyaPalsamudram I added the flag to skip the seed checker. |
ShriyaPalsamudram
approved these changes
Sep 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WG has discussed requiring logging the seeds for official submissions. This PRs contains the changes to reflect that:
Only merge if seed requirement is approved by the WG and changed in the policies/training_policies repositories