Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contenteditable sections and url saving #103

Closed
wants to merge 2 commits into from

Conversation

mkly
Copy link
Member

@mkly mkly commented Feb 16, 2024

  • Add contenteditable sections and url saving

This allows for editing inline various pieces of content which will then save the content to the url which allows it to be shared with the url with the new content on the page. This does not actually save data anywhere.

* Add contenteditable sections and url saving

This allows for editing inline various pieces of content which will then
save the content to the url which allows it to be shared with the url
with the new content on the page. This does not actually save data
anywhere.
@mkly mkly requested a review from wpietri February 16, 2024 17:19
Copy link

github-actions bot commented Feb 16, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@mkly mkly requested a review from dhosterman February 16, 2024 17:19
@mkly
Copy link
Member Author

mkly commented Feb 16, 2024

I should add this is temporary and will be removed before 0.5 It is just to facilitate the production of the copy we need.

@dhosterman
Copy link
Collaborator

I should add this is temporary and will be removed before 0.5 It is just to facilitate the production of the copy we need.

That makes more sense! I was wondering why we needed this at all. Is it to facilitate changes without the need to re-run the tests and such now that --web-only doesn't work properly?

@mkly
Copy link
Member Author

mkly commented Feb 16, 2024

Is it to facilitate changes without the need to re-run the tests and such now that --web-only doesn't work properly?

I'm doing a workaround for that today. So that should be okay.

This is so when a person goes to the demo site, they can actually click in and edit the copy. This doesn't actually go anywhere but it saves the state in the url so they can copy the new url and share it with someone and they'll see the new copy. Generally speaking, this is somewhat useless. The hope is that its a small change that might help encourage and streamline the process of getting the copy we need for these sections.

@mkly
Copy link
Member Author

mkly commented Feb 27, 2024

Closing as per non-approval. Nothing too important. Thanks for taking a look.

@mkly mkly closed this Feb 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
@mkly mkly deleted the mkly/content-editable-1 branch April 12, 2024 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants