Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Practice/heldback prompts switch #690

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Practice/heldback prompts switch #690

merged 6 commits into from
Nov 15, 2024

Conversation

bkorycki
Copy link
Contributor

@bkorycki bkorycki commented Nov 15, 2024

No description provided.

Copy link

github-actions bot commented Nov 15, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@rogthefrog rogthefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

# Only one dependency.
return {
self.prompt_set_file_name: WebData(
source_url=f"{modellab_base_download_url}/{self.prompt_set_file_name}.csv"
Copy link
Collaborator

@dhosterman dhosterman Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to add a ?token=<token> URL param here to get any files that are private or protected.

Update: actually, it'll be an AUTH-TOKEN header, instead!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good to know thanks!

@bkorycki bkorycki merged commit 802b5f1 into main Nov 15, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants