Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLIPS to open_clip #1008

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Yanqing0327
Copy link

Add the CLIPS model, which is trained on public Recap-DataComp-1B.
Performance:
image

@rwightman
Copy link
Collaborator

@Yanqing0327 there's already a config based mechanism to override arguments to the normalization layer,

In the image and vision configs you can add

        "norm_kwargs": {
            "eps":  1e-6
        }

I'm also not quite clear on what the extra logic in the different tokenizer path involves, is there no way to use the existing HFTokenizer wrapper with some minimal pre/post processing that can be enabled via config?

@Yanqing0327
Copy link
Author

Thank you so much for your help! I’ve already added the eps to the config as you suggested. However, for the tokenizer part, I haven’t found a cleaner implementation yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants