Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version limit for protobuf #664

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

SeyedAlirezaFatemi
Copy link
Contributor

Remove the version limit for protobuf since it's no longer needed. The version limit was added because of this issue #246 but that has been resolved in the transformers library with this pull request and commit.

Fixes #623

@SeyedAlirezaFatemi
Copy link
Contributor Author

I think the tests are failing because of the the new change in PyTorch 2.1
"Disallow non-bool masks in torch.masked_{select, scatter, fill}"

@SeyedAlirezaFatemi
Copy link
Contributor Author

Tests should get fixed by #665

@SeyedAlirezaFatemi
Copy link
Contributor Author

Wondering how I can retrigger the CI😁🤔

@SeyedAlirezaFatemi
Copy link
Contributor Author

@gabrielilharco Good to merge?😁

@gabrielilharco
Copy link
Collaborator

tested with protobuf==4.24.4 and all models and tokenizers load without errors

@gabrielilharco gabrielilharco merged commit fa96a32 into mlfoundations:main Oct 12, 2023
5 checks passed
@bryant1410
Copy link
Contributor

Do we need to specify protobuf as a dependency? It's not imported anywhere within this codebase.

Interpause pushed a commit to Interpause/open_clip that referenced this pull request May 23, 2024
Co-authored-by: Gabriel Ilharco Magalhães <gabrielilharco@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version limit for protobuf
3 participants