Add torch flop counter to profiler #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gabrielilharco with this, might be worth putting fvcore import in a try/catch so it'll run natively with torch if fvcore isn't installed (minus act count), and then assert if fvcore profiler is selected and fvcore module not installed? |
|
Good call, will update |
|
Removing hierarchical flop counting for now until pytorch/pytorch#111809 is resolved. With #699 it now works for all supported models |
|
@gabrielilharco looks good, do you want to merge #693 #699 #701 to main and release? |
|
Sounds good! |
Interpause
pushed a commit
to Interpause/open_clip
that referenced
this pull request
May 23, 2024
* Add torch flop counter * Moving fvcore to a try/catch * Fix undesired behavior of `transform.PreprocessCfg` * Remove cls_embed arg from forward/encode_image fns * Fix `model.get_model_preprocess_cfg` * Move CLIPA weights to UCSC-VLAA org * Remove outdated comment in pretrained.py * Fix arg not being passed to `image_transform` from `image_transform_v2` * remove hierarchical flop counting --------- Co-authored-by: Santiago Castro <sacastro@umich.edu> Co-authored-by: Ross Wightman <rwightman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.