made to be null-safe #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awhitford
reviewed
Mar 24, 2021
| @@ -0,0 +1,13 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
This file should be part of the .gitignore. See Flutter gitignore template.
| this.opacity = 0.3, | ||
| this.color = Colors.grey, | ||
| this.progressIndicator = const CircularProgressIndicator(), | ||
| this.offset, | ||
| this.dismissible = false, | ||
| @required this.child, | ||
| required this.child, | ||
| }) : assert(child != null), |
There was a problem hiding this comment.
There is no need to assert(x != null) anymore when x is not a nullable type.
| @@ -64,7 +64,7 @@ class ModalProgressHUD extends StatelessWidget { | |||
| child, | |||
| new Opacity( | |||
There was a problem hiding this comment.
I'd like to see the obsolete new keyword removed too.
| @@ -5,7 +5,7 @@ import 'package:modal_progress_hud/modal_progress_hud.dart'; | |||
|
|
|||
| void main() { | |||
| group('Modal Progress HUD', () { | |||
| Widget sut(bool inAsyncCall, Offset offset) { | |||
| Widget sut(bool inAsyncCall, Offset? offset) { | |||
| return MaterialApp( | |||
| home: new ModalProgressHUD( | |||
| @@ -1,34 +1,55 @@ | |||
| # Generated by pub | |||
There was a problem hiding this comment.
The pubspec.lock file should be part of .gitignore for a library. See Flutter .gitignore Template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated to accomodate null safety.