[feature] SVG Data URL #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/components/code.tsx # app/routes/markdown-to-html.tsx
…d data url images or css backgrounds.
|
Damn sorry @kriserickson but this PR is probably going to have to change a bunch after the image convert stuff merges. |
Yup. Probably be only a few minutes to rewrite though. |
# Conflicts: # app/components/read-file.tsx # app/routes/dataurl.tsx
…ow that it takes drag and drops.).
|
Okay so I am happy to merge now, but here are some thoughts that I don't know what to do about right now:
|
inssein
approved these changes
Jan 3, 2024
|
@kriserickson approving it so feel free to merge, but let me know if you have thoughts on my comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for uploading SVG images and converting them to dataUrls that aren't base64 encoded (https://css-tricks.com/probably-dont-base64-svg/)