copy attestation #37
Merged
copy attestation #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request adds a step to copy the attestation file to the 'dist' directory in the GitHub Actions workflow for deploying build artifacts. It also simplifies the path configuration for the 'Upload build artifact' step. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @mnbf9rca - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Syntax error in the copy command (link)
Here's what I looked at during the review
- 🔴 General issues: 1 blocking issue
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -69,18 +69,18 @@ jobs: | |||
| with: | |||
| subject-path: 'dist/*' | |||
|
|
|||
| - name: copy attestation to dist dir | |||
| run: | | |||
| cp${{ steps.attest-artifacts.outputs.bundle-path }}n $GITHUB_WORKSPACE/dist/attestation.jsonl | |||
There was a problem hiding this comment.
issue (bug_risk): Syntax error in the copy command
There seems to be a missing space between 'cp' and the variable substitution. It should be 'cp ${{ steps.attest-artifacts.outputs.bundle-path }} $GITHUB_WORKSPACE/dist/attestation.jsonl'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
This pull request updates the deploy_build_artifact workflow by adding a step to copy the attestation file to the dist directory before uploading the build artifact.