tidy scripts #69
tidy scripts #69
Conversation
Reviewer's Guide by SourceryThis pull request focuses on tidying up the GitHub Actions workflows by standardizing naming conventions and improving clarity. The changes include correcting the capitalization of 'PyPi' to 'PyPI' and updating job names to be more descriptive and flexible. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @mnbf9rca - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -1,4 +1,4 @@ | |||
| name: Publish the completed package to Pypi | |||
| name: Publish the completed package to PyPi | |||
There was a problem hiding this comment.
issue (typo): Inconsistent capitalization of 'PyPi'
The correct capitalization is 'PyPI'. This should be corrected to maintain consistency and accuracy.
| @@ -45,7 +45,7 @@ jobs: | |||
| # version=$(grep 'version =' pyproject.toml | awk '{print $3}' | sed 's/"//g') | |||
| # echo "VERSION=$version" >> $GITHUB_ENV | |||
| # echo "extracted version '{{ $env.VERSION }}' from pyproject.toml" | |||
| - name: Publish package distributions to TestPyPI | |||
| - name: Publish package distributions to ${{ inputs.target-environment }} | |||
There was a problem hiding this comment.
issue (bug_risk): Potential issue with input variable naming
The input variable 'target-environment' should be checked to ensure it is correctly defined and passed. If it is not defined, this could lead to runtime errors.
| @@ -1,4 +1,4 @@ | |||
| name: build artifact and publish to pypi test | |||
| name: build artifact and publish to pypi | |||
There was a problem hiding this comment.
issue (typo): Inconsistent capitalization of 'pypi'
The correct capitalization is 'PyPI'. This should be corrected to maintain consistency and accuracy.
Summary by Sourcery
This pull request updates the CI workflows by renaming them for better clarity and making the target environment for publishing package distributions dynamic.