Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attestations flag to PyPI deployment workflow #81

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

mnbf9rca
Copy link
Owner

@mnbf9rca mnbf9rca commented Sep 11, 2024

Summary by Sourcery

Add an 'attestations' flag to the PyPI deployment workflow to enhance the deployment process.

Deployment:

  • Add an 'attestations' flag to the PyPI deployment workflow configuration.

Copy link

sourcery-ai bot commented Sep 11, 2024

Reviewer's Guide by Sourcery

This pull request adds an attestation flag to the PyPI deployment workflow, enhancing the security and traceability of the package publishing process.

File-Level Changes

Change Details Files
Enable attestations in the PyPI deployment workflow
  • Add 'attestations: true' to the workflow configuration
.github/workflows/deploy_to_pypi.yml

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mnbf9rca - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The code change looks good, but it would be helpful to provide some context in the pull request description. Could you explain the rationale for adding the attestations flag and any potential benefits or implications of this change?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@mnbf9rca mnbf9rca merged commit a3de6b8 into main Sep 11, 2024
8 of 9 checks passed
@mnbf9rca mnbf9rca deleted the chore/add_attestations_to_pypi branch September 12, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant