-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console System Improvements #46
Merged
xezno
merged 20 commits into
mocha-engine:master
from
MuffinTastic:MuffinTastic/cvar-system-improvements
Jan 31, 2023
Merged
Console System Improvements #46
xezno
merged 20 commits into
mocha-engine:master
from
MuffinTastic:MuffinTastic/cvar-system-improvements
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rguments to commands.
# Conflicts: # Source/Hotload/Main.cs
LGTM, thanks a ton for this! Should make both engine & game development much easier, and I do feel your concerns about string operations in c++ - I think they suck too - but I think your solution works fine. Awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
CCmd
classConCmd.X
attributes (only a couple exist right now)"
, enabling the passing of string arguments containing spaces;
and newlines\n
//
list
command has been made aCCmd
instance, and now lists the flags of each command and variableUsage Examples
Native CVar with a callback
Native CCmd
Several managed ConCmds
Notes:
While the bindings for registering managed ConVars are there you currently can't make them at the moment, because that really should be done through static properties, but source generation is not my forté. Happy to implement suggestions, unless you want to merge and do it yourself
A few CVarSystem methods (
GetString()
,ToString()
) don't have bindings right now due to memory leak concernsPossible interop memory leak when passing temporary strings from native to managed #43