Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: replace "New in" with "Since" in version annotations #5262

Merged
merged 3 commits into from
Dec 9, 2024
Merged

docs: replace "New in" with "Since" in version annotations #5262

merged 3 commits into from
Dec 9, 2024

Conversation

TG199
Copy link
Contributor

@TG199 TG199 commented Nov 24, 2024 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Changes version annotations from "New in vX.Y.Z" to "Since vX.Y.Z".

@TG199
docs: replace "New in" with "Since" in version annotations
cf77148 
* Change version annotations from "New in vX.Y.Z" to "Since vX.Y.Z"
* Align with Node.js documentation style convention
* Improve clarity for users upgrading from older versions

Closes mochajs#5166
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 24, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks great to me, thanks for the first PR @TG199! A few small typos but you've got it correct otherwise.

Black cat using a nail file. Caption: "excellent"

docs/index.md Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author waiting on response from OP - more information needed label Nov 24, 2024
@JoshuaKGoldberg
Copy link
Member

  • [ x ]

By the way, it's [x], not [ x ] (note the spaces). A nice little github.com feature: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists

@TG199
Copy link
Contributor Author

TG199 commented Nov 24, 2024

  • [ x ]

By the way, it's [x], not [ x ] (note the spaces). A nice little github.com feature: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-task-lists

Noted!

JoshuaKGoldberg
JoshuaKGoldberg requested changes Nov 24, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh shoot sorry, I pressed the wrong button 🤦

Requesting changes on the typos please.

@TG199 @JoshuaKGoldberg
Update docs/index.md
066639c 
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
JoshuaKGoldberg
JoshuaKGoldberg reviewed Dec 4, 2024
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6f10d12 into mochajs:main Dec 9, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Dec 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
status: waiting for author waiting on response from OP - more information needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📝 Docs: Rephrase "New in ..." notices on versions to say "Since ..."
2 participants
@TG199 @JoshuaKGoldberg