Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

an "operations" field #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

an "operations" field #24

wants to merge 2 commits into from

Conversation

roblatham00
Copy link
Contributor

Instead of implying bulk transfers based on size, make the kind of
operation we are doing explicit

Copy link
Member

@carns carns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just put in a couple of suggestions to resolve.

include/quintain.h Outdated Show resolved Hide resolved
src/quintain-benchmark.c Show resolved Hide resolved
@carns carns self-assigned this Aug 12, 2022
Instead of implying bulk transfers based on size, make the kind of
operation we are doing explicit
@roblatham00
Copy link
Contributor Author

coming back to this after some distractions. thanks for the suggestions. I tried with a bunch of the built-in json configs

@carns
Copy link
Member

carns commented Oct 10, 2022

Something is still weird. I haven't checked the code yet, but I still don't see the operation field getting set in the json:

carns-x1-7g ~/w/s/m/m/build (dev-operations=)> mpiexec -n 4 src/quintain-benchmark -g quintain.ssg -j ../tests/quintain-benchmark-example.json -o foo
# SSG group refreshed; proceeding with benchmark.
carns-x1-7g ~/w/s/m/m/build (dev-operations=)> zcat foo.gz |grep operation
carns-x1-7g ~/w/s/m/m/build (dev-operations=) [0|1]>  

That particular json has defaults for everything (except for setting one mercury parameter, see below), but the benchmark should fill in the default value to show what was used in the run.

{
    "margo": {
        "mercury": {
            "auto_sm":true
        }
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants