Nanobenchmarks #4143
Merged
Nanobenchmarks #4143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleroy
reviewed
Dec 29, 2024
| using namespace principia::nanobenchmarks::_performance_settings_controller; | ||
| using namespace principia::testing_utilities::_statistics; | ||
|
|
||
| struct LatencyDistributionTable { |
There was a problem hiding this comment.
Let's move this struct to its own file with proper hpp/cpp separation. Also, maybe make it a class?
There was a problem hiding this comment.
The logic is all formatting, which is coupled to main, and the structure is tied to the Benchmark function. Let’s untangle that some other day.
| Benchmark(BenchmarkedFunction f, Logger* logger) { | ||
| std::size_t const sample_count = absl::GetFlag(FLAGS_samples); | ||
| std::size_t const loop_iterations = absl::GetFlag(FLAGS_loop_iterations); | ||
| static std::vector<double>& samples = *new std::vector<double>( |
There was a problem hiding this comment.
Let's use a pointer, not a reference, to avoid depending on lifetime extension.
There was a problem hiding this comment.
Lifetime is obvious : *new, we leak.
Let’s not litter the code with (*) below.
|
|
||
| FunctionRegistry& FunctionRegistry::singleton_ = *new FunctionRegistry(); | ||
|
|
||
| std::map<std::string, BenchmarkedFunction, std::less<>> const& |
There was a problem hiding this comment.
These are ordered, so that the tests show up in alphabetical(ish) order; we don’t use absl ordered maps unless we have a good reason to.
pleroy
approved these changes
Dec 29, 2024
| @@ -162,6 +219,21 @@ std::string_view WindowsPerformanceSettingsController::PerfBoostModeToString( | |||
| }; | |||
| #undef PRINCIPIA_PROCESSOR_PERF_BOOST_MODE_CASE | |||
|
|
|||
| #define PRINCIPIA_PROCESSOR_PROCESSOR_THROTTLE(value) \ | |||
| case PROCESSOR_THROTTLE_##value: \ | |||
| return #value | |||
| return "Unknown"; | ||
| } | ||
| }; | ||
| #undef PRINCIPIA_PROCESSOR_PERF_BOOST_MODE_CASE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.