[Waiting] mod: Lit protocol token gated casts #92

davidfurlong · 2023-11-24T12:32:56Z

This PR:

Adds the lit-protocol and lit-protocol-renderer mini-apps

There's a blocker right now for releasing this Miniapp:
Lit protocol is upgrading to v3 (mainnet) which is called Habanero, and is scheduled for December. The v3 testnet is not persistent, is unstable, and has breaking changes every couple days, requiring a node package update to fix.

Other todos:

hot reloading breaks the encryption endpoint locally (somewhere in the lit library), tbd what happens in prod.
unclear whether signature needs to have the same chainid as the access control rules (maybe not)
needs changesets
Deployment needs new env variables
Consider whether/how this complies by the iOS app store rules, and add a permission or categorization for it "From 3.1.1 "Apps may allow users to view their own NFTs, provided that NFT ownership does not unlock features or functionality within the app."
Required JSON schema array

It creates links using the new gateway: https://github.com/mod-protocol/gateway , which would need to be deployed first

Demo (broken due to cayenne downtime)

Depends on #101

changeset-bot · 2023-11-24T12:33:01Z

⚠️ No Changeset found

Latest commit: 3543d13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2023-11-24T12:33:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 27, 2023 2:52pm
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 27, 2023 2:52pm
example-nextjs-shadcn	❌ Failed (Inspect)			Nov 27, 2023 2:52pm

stephancill

Looking good. Left some notes

examples/api/src/app/api/cast-embeds-metadata/by-url/route.ts

stephancill · 2023-11-24T14:11:04Z

docs/pages/metadata-cache.mdx

+```
+
+## `/api/cast-embeds-metadata/by-url`


We should consider renaming these endpoints. I suggest /embed-metadata/by-casts and /embed-metadata/by-urls

agreed, but that means no backwards compat; will have to let integrators know

examples/api/next.config.js

stephancill · 2023-11-24T14:18:59Z

examples/api/src/app/api/lit-protocol-renderer/route.ts

+  return decryptedString;
+}
+
+// async function retrieveFromIrys(id: string) {


Can be removed if was used for debugging

hm yeah this was an alternate way of doing it, that I thought may make sense in some scenarios

stephancill · 2023-11-24T14:22:20Z

examples/api/src/app/api/lit-protocol/route.ts

+  // 1. Encryption
+  // <Blob> encryptedString
+  // <Uint8Array(32)> dataToEncryptHash`
+  const { ciphertext, dataToEncryptHash } = await LitJsSdk.encryptString(


Assuming encryption is happening on server to save client bundle size?

yeah, also Mini-apps can't load arbitrary JS today

theoretically this backend function here could be run a secure JS env on a client; not sure how much their lib depends on node apis directly

packages/core/src/manifest.ts

packages/core/src/renderer.ts

turbo.json

stephancill · 2023-11-24T14:45:20Z

miniapps/lit-protocol/src/action.ts

+      {
+        type: "textarea",
+        ref: "plaintext",
+        placeholder: "Content to token gate",
+      },


Is there a reason why this doesn't use the cast text content?

good question - the cast contents includes mentions (that won't work) and special renderers (like textcuts) that Mini-apps can't directly use. Additionally casts include embeds that we can't easily render if we added them to the encrypted contents, and token gated casts would probably still include or be able to include the cast body; so it'd be a bit confusing to have the cast text appearing/disappearing, or for it to somehow be encrypted when submitted.

In short, I'm not sure our abstractions are particularly close to supporting it in a graceful manner

packages/miniapp-registry/src/index.ts

…url endpoint

vercel bot deployed to Preview – docs November 24, 2023 12:33 View deployment

davidfurlong requested a review from stephancill November 24, 2023 12:47

stephancill requested changes Nov 24, 2023

View reviewed changes

vercel bot deployed to Preview – docs November 27, 2023 14:12 View deployment

vercel bot deployed to Preview – api November 27, 2023 14:14 View deployment

vercel bot had a problem deploying to Preview – example-nextjs-shadcn November 27, 2023 14:15 Failure

davidfurlong and others added 6 commits November 27, 2023 15:17

feat: add select element, add lit-protocol miniapps, add metadata by …

49543ce

…url endpoint

chore: commit progress

076b879

miniapp(zora-minter): initial commit

fc19161

chore: commit progress

0cafd6d

chore: add combobox, textarea, token gating mvp

4344462

fix: pr comment

3543d13

davidfurlong force-pushed the feat/token-gated-casts branch from 73aea35 to 3543d13 Compare November 27, 2023 14:47

vercel bot had a problem deploying to Preview – example-nextjs-shadcn November 27, 2023 14:50 Failure

vercel bot deployed to Preview – api November 27, 2023 14:50 View deployment

vercel bot deployed to Preview – docs November 27, 2023 14:52 View deployment

davidfurlong changed the title ~~Miniapp: token gated casts~~ Miniapp: Lit protocol token gated casts Dec 1, 2023

davidfurlong mentioned this pull request Dec 1, 2023

Feat: Core SDK improvements necessary for token gated mini apps #101

Merged

3 tasks

davidfurlong changed the title ~~Miniapp: Lit protocol token gated casts~~ [Blocked] Miniapp: Lit protocol token gated casts Dec 1, 2023

davidfurlong added the mod label Dec 1, 2023

davidfurlong changed the title ~~[Blocked] Miniapp: Lit protocol token gated casts~~ [Blocked] miniapp: Lit protocol token gated casts Dec 1, 2023

davidfurlong changed the title ~~[Blocked] miniapp: Lit protocol token gated casts~~ [Waiting] mod: Lit protocol token gated casts Dec 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Waiting] mod: Lit protocol token gated casts #92

[Waiting] mod: Lit protocol token gated casts #92

davidfurlong commented Nov 24, 2023 •

edited

Loading

changeset-bot bot commented Nov 24, 2023 •

edited

Loading

vercel bot commented Nov 24, 2023 •

edited

Loading

stephancill left a comment

stephancill Nov 24, 2023

davidfurlong Nov 27, 2023

davidfurlong Nov 27, 2023

stephancill Nov 24, 2023

davidfurlong Nov 27, 2023

stephancill Nov 24, 2023

davidfurlong Nov 27, 2023

davidfurlong Nov 27, 2023

stephancill Nov 24, 2023

davidfurlong Nov 27, 2023

		```

		## `/api/cast-embeds-metadata/by-url`

[Waiting] mod: Lit protocol token gated casts #92

Are you sure you want to change the base?

[Waiting] mod: Lit protocol token gated casts #92

Conversation

davidfurlong commented Nov 24, 2023 • edited Loading

changeset-bot bot commented Nov 24, 2023 • edited Loading

⚠️ No Changeset found

vercel bot commented Nov 24, 2023 • edited Loading

stephancill left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidfurlong commented Nov 24, 2023 •

edited

Loading

changeset-bot bot commented Nov 24, 2023 •

edited

Loading

vercel bot commented Nov 24, 2023 •

edited

Loading