Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODCLUSTER-807 Change the mod_cluster license to ASL 2.0 #760

Merged
merged 2 commits into from
Dec 10, 2023
Merged

MODCLUSTER-807 Change the mod_cluster license to ASL 2.0 #760

merged 2 commits into from
Dec 10, 2023

Conversation

rhusar
Copy link
Member

@rhusar rhusar commented Dec 5, 2023

@rhusar rhusar marked this pull request as ready for review December 7, 2023 10:39
jajik
jajik requested changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@jajik jajik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the http instead of httpS it looks correct.

I left there some comments about inconsistent blank spaces after comments, but that's not an issue.

container/spi/src/main/java/org/jboss/modcluster/container/Connector.java Outdated Show resolved Hide resolved
container/tomcat-8.5/src/main/java/org/jboss/modcluster/container/tomcat/mbeans-descriptors.xml Outdated Show resolved Hide resolved
container/tomcat-9.0/src/main/java/org/jboss/modcluster/container/tomcat/mbeans-descriptors.xml Outdated Show resolved Hide resolved
core/src/main/java/org/jboss/modcluster/config/ProxyConfiguration.java Outdated Show resolved Hide resolved
core/src/main/java/org/jboss/modcluster/config/builder/AbstractConfigurationBuilder.java Outdated Show resolved Hide resolved
core/src/main/java/org/jboss/modcluster/config/builder/AdvertiseConfigurationBuilder.java Outdated Show resolved Hide resolved
core/src/main/java/org/jboss/modcluster/config/builder/BalancerConfigurationBuilder.java Outdated Show resolved Hide resolved
core/src/main/java/org/jboss/modcluster/config/builder/ConfigurationBuilder.java Outdated Show resolved Hide resolved
core/src/main/java/org/jboss/modcluster/config/builder/Creator.java Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@rhusar rhusar requested a review from jajik December 7, 2023 11:55
jajik
jajik requested changes Dec 7, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@rhusar rhusar requested a review from jajik December 7, 2023 13:31
jajik
jajik approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@jajik jajik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhusar rhusar added this to the 2.0.4.Final milestone Dec 10, 2023
@rhusar rhusar self-assigned this Dec 10, 2023
@rhusar rhusar merged commit f08e6c5 into modcluster:main Dec 10, 2023
9 checks passed
@rhusar rhusar deleted the MODCLUSTER-807 branch December 10, 2023 23:38
@rhusar
Copy link
Member Author

rhusar commented Dec 10, 2023 •
edited
Loading

Thanks for the 2nd pair of eyes review @jajik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jajik jajik jajik approved these changes

Assignees

@rhusar rhusar

Labels
None yet
Projects
None yet
Milestone
2.0.4.Final
Development

Successfully merging this pull request may close these issues.
2 participants
@rhusar @jajik