Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODCLUSTER-812 Configure jboss-logging annotation processing via maven-compiler-plugin's annotationProcessorPaths + add JDK 22-ea support #763

Merged
merged 2 commits into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,14 @@ jobs:
matrix:
os: [ ubuntu-latest, windows-latest, macos-latest ]
# Keep this list as: all supported LTS JDKs, the latest GA JDK, and the latest EA JDK (if available).
java: [ 11, 17, 21 ]
java: [ 11, 17, 21, 22-ea ]
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Set up JDK ${{ matrix.java }}
uses: actions/setup-java@v4
with:
# Use 'oracle' distribution for JDK 21 until 'temurin' is available.
distribution: ${{ matrix.java == 21 && 'oracle' || 'temurin' }}
distribution: temurin
java-version: ${{ matrix.java }}
- name: Cache local Maven repository
uses: actions/cache@v3
Expand Down
14 changes: 13 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,18 @@
</goals>
<configuration>
<release>${jdk.release.version}</release>
<annotationProcessorPaths>
<path>
<groupId>org.jboss.logging</groupId>
<artifactId>jboss-logging-processor</artifactId>
<version>${version.jboss-logging-processor}</version>
</path>
<path>
<groupId>org.jboss.logging</groupId>
<artifactId>jboss-logging</artifactId>
<version>${version.jboss-logging}</version>
</path>
</annotationProcessorPaths>
</configuration>
</execution>
</executions>
Expand Down Expand Up @@ -252,7 +264,7 @@
<failsOnError>true</failsOnError>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<excludes>**/*$logger.java,**/*$bundle.java</excludes>
<useFile />
<useFile/>
</configuration>
</plugin>
<plugin>
Expand Down