Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODCLUSTER-779 Remove or fix broken links in logs pointing to jboss.org #860

Merged
merged 1 commit into from
Dec 17, 2024
Merged

MODCLUSTER-779 Remove or fix broken links in logs pointing to jboss.org #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/org/jboss/modcluster/ModClusterLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public interface ModClusterLogger {
// void createMulticastSocketWithUnicastAddress(InetAddress address);

@LogMessage(level = WARN)
@Message(id = 31, value = "Could not bind multicast socket to %s (%s address): %s; make sure your multicast address is of the same type as the IP stack (IPv4 or IPv6). Multicast socket will not be bound to an address, but this may lead to cross talking (see https://developer.jboss.org/docs/DOC-9469 for details).")
@Message(id = 31, value = "Could not bind multicast socket to %s (%s address): %s; make sure your multicast address is of the same type as the IP stack (IPv4 or IPv6). Multicast socket will not be bound to an address, but this may lead to crosstalking.")
void potentialCrossTalking(InetAddress address, String addressType, String message);

@LogMessage(level = INFO)
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/org/jboss/modcluster/advertise/impl/DatagramChannelFactoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
/**
* On Linux-like systems, we attempt to avoid cross-talk problem by binding the DatagramChannel to the multicast
* address, if possible. If not possible, default to binding only to the port. See
* {@link <a href="https://issues.jboss.org/browse/JGRP-777">JGRP-777</a>}.
* {@link <a href="https://issues.redhat.com/browse/JGRP-777">JGRP-777</a>}.
* <p>
* On Windows-like systems, we do not attempt to bind the socket to the multicast address, we only bind to the port.
* <p>
Expand Down
6 changes: 4 additions & 2 deletions ...src/test/java/org/jboss/modcluster/advertise/impl/DatagramChannelFactoryImplTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,11 @@ public void testDatagramChannelRead() throws Exception {
}

/**
* Verify that cross-talking problem does not happen any more.
* Verify that crosstalking problem does not happen anymore.
*
* @see <a href="https://developer.jboss.org/wiki/CrossTalkingBetweenClustersWithSameMulticastPortsButDifferentMulticastAddresses">Cross-talking wiki</a>
* @see <a href="https://developer.jboss.org/docs/DOC-9469">Crosstalking between clusters with same multicast ports but different multicast addresses</a>
* @see <a href="https://issues.redhat.com/browse/JGRP-777">JGRP-777 Revisit multicast socket creation code</a>
* @see <a href="https://issues.redhat.com/browse/JGRP-836">JGRP-836 Eliminate Linux cross-talk in MPING</a>
*/
@Test
public void testDatagramChannelNoCrossTalking() throws Exception {
Expand Down
Loading