Use stable version to install Kani #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
reviewed
Jan 10, 2024
|
Can you clarify what you mean? The action installs the stable toolchain: Line 38 in e621a98 |
camshaft
approved these changes
Jan 10, 2024
celinval
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The action currently uses
cargo install ...to install Kani. If the command is issued from a path that has arust-toolchainfile, this results incargousing the version specified in the toolchain file to install Kani. However, we should always use stable, as the toolchain version could be too old, which would cause the installation to fail, e.g.https://github.com/aws/s2n-quic/actions/runs/7467601009/job/20322602354?pr=2085#step:3:292
Resolved issues:
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.