Skip to content

Commit

Permalink
Toolchain update: avoid Javascript interpreting git log (#3421)
Browse files Browse the repository at this point in the history
git log entries may themselves use backticks, which prematurely ended
the string (and then caused Javascript syntax errors). Avoid this
problem by using the environment variable rather than having Javascript
see the string contents (of that environment variable).

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.

Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
  • Loading branch information
tautschnig and adpaco-aws committed Aug 6, 2024
1 parent 2a0e9bd commit c515d66
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/toolchain-upgrade.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
https://github.com/rust-lang/rust/commit/${{ env.next_toolchain_hash }}. The log
for this commit range is:
${{ env.git_log }}`
` + process.env.git_log
})
- name: Create Issue
Expand Down

0 comments on commit c515d66

Please sign in to comment.