Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #2528

Merged
merged 2 commits into from
Jun 17, 2023

Conversation

karkhaz
Copy link
Contributor

@karkhaz karkhaz commented Jun 14, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@karkhaz karkhaz requested a review from a team as a code owner June 14, 2023 21:50
@karkhaz karkhaz enabled auto-merge (squash) June 14, 2023 22:11
@karkhaz karkhaz disabled auto-merge June 14, 2023 22:12
@karkhaz
Copy link
Contributor Author

karkhaz commented Jun 14, 2023

On this run there was a 58% increase in solver runtime (59s -> 93s) for s2n-quic/quic/s2n-quic-core/slice::tests::vectored_copy_fuzz_test, will re-run just in case

@zhassan-aws
Copy link
Contributor

On this run there was a 58% increase in solver runtime (59s -> 93s) for s2n-quic/quic/s2n-quic-core/slice::tests::vectored_copy_fuzz_test, will re-run just in case

This always happens mysteriously with version bumps!

@zhassan-aws
Copy link
Contributor

Or rather, with many PRs. See for example this PR that adds an RFC :)

https://github.com/model-checking/kani/actions/runs/5272168064

@adpaco-aws
Copy link
Contributor

Or rather, with many PRs. See for example this PR that adds an RFC :)

https://github.com/model-checking/kani/actions/runs/5272168064

Yeah, getting a couple CI failures in that PR was surprising to me. I guess the SAT procedure for benchmark is unstable? I wonder if we should start documenting the issue and keeping a list of unstable benchmarks.

@celinval
Copy link
Contributor

Or rather, with many PRs. See for example this PR that adds an RFC :)
https://github.com/model-checking/kani/actions/runs/5272168064

Yeah, getting a couple CI failures in that PR was surprising to me. I guess the SAT procedure for benchmark is unstable? I wonder if we should start documenting the issue and keeping a list of unstable benchmarks.

Not surprised at all. We've been seeing this instability issue since we added this regression even for changes to the documentation.

I think adding the list of unstable tests will help, but we really need to investigate a bit more. Is Kani performance that unstable (which would be a poor experience for our users) or is this an infrastructure issue?

@zhassan-aws zhassan-aws merged commit 8b02f2c into model-checking:main Jun 17, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants