[Draft] Introduce global conditions with support for fail_uncoverable
(new condition) and should_panic
(rework)
#2532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In this draft PR we:
should_panic
feature as a global conditionfail_uncoverable
conditionThe PR has been opened to serve as a Proof-of-Concept for #2516 , therefore it's not recommended to review it unless the PR has been merged (I'll update the description when that happens).
Resolved issues:
Resolves #2299
Related RFC:
Optional #2516 , #2272 , #1905
Call-outs:
There are a few things to be done for this implementation. One thing I'm considering is moving all
struct
s and logic related to global conditions to a new module. Another one is to convert thecompute_<cond>_condition
into associated functions ofGlobalCondition
.Testing:
How is this change tested? New tests.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.