Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install doc dependencies before building #2564

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

karkhaz
Copy link
Contributor

@karkhaz karkhaz commented Jun 23, 2023

This fixes a Graphviz graph not being rendered in the Kani book.

Description of changes:

Currently this page of the Kani book contains Graphviz source code. This is supposed to be rendered as an actual diagram, similar to this page (or this screenshot if that page disappears)

Screen Shot 2023-06-23 at 23 08 25

Resolved issues:

N/A

Related RFC:

N/A

Call-outs:

N/A

Testing:

  • How is this change tested?

This successful run on my fork resulted in the diagram being rendered in my this page (screenshot above in case I push something else meanwhile)

  • Is this a refactor change?

No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

This fixes a Graphviz graph not being rendered in the Kani book.
@karkhaz karkhaz requested a review from a team as a code owner June 23, 2023 22:11
@karkhaz karkhaz enabled auto-merge (squash) June 26, 2023 12:42
@karkhaz karkhaz merged commit 987c9ce into model-checking:main Jun 26, 2023
@karkhaz karkhaz deleted the kk-fix-doc-graph branch June 26, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants