Delay writing metadata file (no UX impact) #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change required for model-checking#2493 and contracts work. This will allow us to store information collected during code generation.
|
Can you clarify in the description which compilation stage the writing of the metadata file was delayed to (and which stage it was currently written in)? |
JustusAdam
reviewed
Jul 28, 2023
|
Also, not trying to rush (well maybe a bit) but I'm sorta waiting for this to get merged so I can finish the contracts rewrite that uses stubbing. |
|
Nice |
JustusAdam
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Kani compiler will now only store KaniMetadata after compiling all harnesses. Before, we were storing before codegen in the first iteration of the compiler.
This will still allow us to generate metadata without actually performing codegen, if we ever implement a
kani listsubcommand. The metadata won't be stored though if Kani fails to codegen. However, we don't do anything extra with that file if the compilation fails.This change is required for #2493 and contracts work. This will allow us to store information collected during code generation.
Resolved issues:
Related to #2493
Related RFC:
N/A
Call-outs:
Testing:
How is this change tested? Existing tests
Is this a refactor change? yes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.