Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unchecked/SIMD bitshift checks and disable CBMC flag #2630

Merged
merged 8 commits into from
Jul 31, 2023
Merged

Add unchecked/SIMD bitshift checks and disable CBMC flag #2630

merged 8 commits into from
Jul 31, 2023

Commits on Jul 24, 2023

  1. Implement unchecked shift checks in Kani

    @reisnera
    reisnera committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    50be9ab View commit details
    Browse the repository at this point in the history

  2. Add overflow checks for simd shift intrinsics

    @reisnera
    reisnera committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    eefab81 View commit details
    Browse the repository at this point in the history

  3. Remove CBMC undefined-shift-check flag 

    Checks are now implemented in Kani
    @reisnera
    reisnera committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    a567e68 View commit details
    Browse the repository at this point in the history

  4. Fix/update tests 

    Remove tests for shifting a negative value as that is not UB in rust.
    @reisnera
    reisnera committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    949ee78 View commit details
    Browse the repository at this point in the history

  5. Use signed-ness of discance rather than value

    @reisnera
    reisnera committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    eb8af25 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Fix order of items in Stmt::blocks 

    Co-authored-by: Celina G. Val <celinval@amazon.com>
    @reisnera @celinval
    reisnera and celinval authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7a87569 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Test expected results when shifting negative vals

    @reisnera
    reisnera committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    bac1926 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Merge branch 'main' into shift-checks

    @adpaco-aws
    adpaco-aws authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    235de82 View commit details
    Browse the repository at this point in the history