Propogate backend options into goto-synthesizer #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
reviewed
Aug 11, 2023
goto-synthesizer should take the same backend options as cbmc to make sure that the checker that we used in Kani to check loop-contracts candidates is the same as the checker we verify the final goto-binary.
qinheping
force-pushed
the
synthesizer-args
branch
from
82bc123
to
d8cb014
Compare
|
Looks good. We'll need to wait for a new CBMC release that includes diffblue/cbmc#7900 before merging though, right? |
Yes, we should merge this PR after CBMC 5.94.0 published. |
zhassan-aws
approved these changes
Oct 11, 2023
celinval
previously requested changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
goto-synthesizershould take the same backend options ascbmcto make sure that the checker we used to check loop-contracts candidates is the same as the checker we verify the final goto-binary.CBMC backend options: https://github.com/diffblue/cbmc/blob/develop/src/cbmc/cbmc_parse_options.cpp#L993C1-L1000C58 including
object-bitsoption (propagated in this PR)array-ufoptions (propagated in this PR)Resolved issues:
Resolves #ISSUE-NUMBER
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.