Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run performance benchmarks for tags #2745

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

adpaco-aws
Copy link
Contributor

Description of changes:

Currently, the performance benchmarks also run when pushing kani-* tags, which is essentially done each time we're going to publish a new release. In that case, the performance CI job fails with the error:

Initializing the repository
Disabling automatic garbage collection
Setting up auth
Fetching the repository
  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=2 origin 0000000000000000000000000000000000000000
  Error: fatal: remote error: upload-pack: not our ref 0000000000000000000000000000000000000000
  The process '/usr/bin/git' failed with exit code 128
  Waiting 17 seconds before trying again

There's at least two occasions in which I've seen this happen:

It doesn't make sense to run performance benchmarks in this case, since the candidate commit will have already triggered a performance benchmarks CI job when it's merged into main.

Resolved issues:

Resolves #2744

Testing:

  • How is this change tested? N/A (changes to GA workflows cannot be tested)

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner September 7, 2023 18:03
@adpaco-aws adpaco-aws merged commit 1e3409d into model-checking:main Sep 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

perf-benchcomp CI fails when pushing a new release
2 participants