Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build files generated with cargo doc command #2750

Merged
merged 2 commits into from
Sep 9, 2023

Conversation

adpaco-aws
Copy link
Contributor

Description of changes:

Remove build files to avoid false positives in secret scanning alerts (more details in #2735) in scripts/build-docs.sh.

Resolved issues:

Resolves #2735

Call-outs:

We could instead add an extra step to the kani.yml workflow to do the same. That'd allow us to keep build files when we build the docs locally. But I think that's a rare scenario, and I'd rather keep this in the doc-building script which is already doing similar things.

Testing:

  • How is this change tested? Locally.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner September 8, 2023 18:16
@tautschnig tautschnig enabled auto-merge (squash) September 9, 2023 12:10
@tautschnig tautschnig merged commit 7334ba1 into model-checking:main Sep 9, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build files are being deployed to gh-pages
2 participants