Unify Kani bundle CI jobs #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have two different ways today of building and testing release bundles, one in `kani.yml` and another one in `release.yml`. This is error prone, since the release workflow only runs during a release, and it can diverge from what's being tested in CI. Instead, we will always run the same workflow, except for the steps that create the release.
celinval
force-pushed
the
issue-2703-bundle-test
branch
2 times, most recently
from
84c0d66
to
9337c97
Compare
celinval
force-pushed
the
issue-2703-bundle-test
branch
from
9337c97
to
de0c21d
Compare
|
Note that to merge this PR, we will need to remove the "Required" check from the jobs that were removed |
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two different ways today of building release bundles, one in
kani.ymland another one inrelease.yml, and only thekani.ymlactually run tests. This is error prone, since the release workflow only runs during a release without validation tests, and the build can diverge from what's being tested in CI.Instead, we will always run the same workflow, except for the steps that create the release.
Resolves #2703
Call-outs
continue-on-error: trueso it doesn't fail the release workflow.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.