-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues and Update toolchain 10-26 #2843
Fix issues and Update toolchain 10-26 #2843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks Jai
Despite this looking like a simple renaming, there is a performance regression in the
@zhassan-aws @tautschnig have you seen this benchmark fail lately? Do you have any suggestions? |
@adpaco-aws, the second issue rust-lang/rust#117103 required very minor refactoring, which is contained in this commit dce6524. It's possible that this could be causing the performance regression. |
Hi @jaisnan, can you compare the MIR emitted before and after the toolchain upgrade (Instruction here)? My guess is that the performance impact doesn't have anything to do with the conflict resolutions but more with an underlying change to the compiler. |
I ran My findings were:
Before:
After:
|
We agreed to merge the PR and continue the investigation in a separate issue. @jaisnan do you mind opening that? |
Resolves issues caused by
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.